feat(wallet-mobile): Add dApp Explorer feature flag and rename variables #3190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljscript
changed the title
jorbuedo
reviewed
Apr 11, 2024
jorbuedo
approved these changes
Apr 11, 2024
stackchain
reviewed
Apr 11, 2024
| const {isEdit} = router.params ?? {isEdit: false} | ||
| const navigateTo = useNavigateTo() | ||
| const {addBrowserTab, setTabActive, updateTab, tabs, tabActiveIndex} = useBrowser() | ||
| const tabActive = tabs[tabActiveIndex] | ||
| const [searchValue, setSearchValue] = useState('') | ||
| const [searchValue, setSearchValue] = React.useState('') |
There was a problem hiding this comment.
heads up: we have a hook + provider that transforms the navbar into a searchable bar. (dunno if it's applied on nav bar this one)
There was a problem hiding this comment.
We have the hook used in SelectDappFromListScreen, but this component is the search in the browser, which has a different UI, so I'd say it's okay to use a custom component
stackchain
reviewed
Apr 11, 2024
apps/wallet-mobile/src/features/Discover/useCases/BrowseDapp/BrowserToolbar.tsx
Show resolved
Hide resolved
stackchain
reviewed
Apr 11, 2024
apps/wallet-mobile/src/features/Discover/useCases/BrowseDapp/BrowserToolbar.tsx
Show resolved
Hide resolved
stackchain
reviewed
Apr 11, 2024
| @@ -23,7 +23,7 @@ export const BrowserTabsBar = () => { | |||
|
|
|||
| const handleCreateTab = () => { | |||
| switchTab(false) | |||
| navigateTo.browserSearch(false) | |||
| navigateTo.searchDappInBrowser({isEdit: false}) | |||
There was a problem hiding this comment.
params are unsafe, later if possible move to state
There was a problem hiding this comment.
I'll refactor this. It looks like we don't need params nor state
stackchain
reviewed
Apr 11, 2024
| screen: 'browser-view', | ||
| }), | ||
| selectDappFromList: () => navigation.navigate('discover-select-dapp-from-list'), | ||
| browseDapp: () => navigation.navigate('discover-browser', {screen: 'discover-browse-dapp'}), | ||
| navigation: () => navigation, |
stackchain
reviewed
Apr 11, 2024
| screen: 'browser-view', | ||
| }), | ||
| selectDappFromList: () => navigation.navigate('discover-select-dapp-from-list'), | ||
| browseDapp: () => navigation.navigate('discover-browser', {screen: 'discover-browse-dapp'}), | ||
| navigation: () => navigation, |
There was a problem hiding this comment.
Suggested change
| navigation: () => navigation, |
stackchain
reviewed
Apr 11, 2024
| @@ -106,7 +106,7 @@ export const BrowserProvider = ({ | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
@michaeljscript this is looking confusing and with a lot of var shadowing, can you give it a look?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves YOMO-1296