fix(wallet-setup): duplicated wallet warning #3194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banklesss
requested review from
jorbuedo,
michaeljscript,
stackchain and
SorinC6
banklesss
commented
Apr 12, 2024
apps/wallet-mobile/src/features/SetupWallet/useCases/RestoreWallet/RestoreWalletScreen.tsx
Outdated
Show resolved
Hide resolved
stackchain
reviewed
Apr 12, 2024
apps/wallet-mobile/src/features/SetupWallet/useCases/RestoreWallet/RestoreWalletScreen.tsx
Outdated
Show resolved
Hide resolved
stackchain
reviewed
Apr 12, 2024
apps/wallet-mobile/src/features/SetupWallet/useCases/RestoreWallet/RestoreWalletScreen.tsx
Outdated
Show resolved
Hide resolved
|
move onto release 4.27 |
banklesss
changed the base branch from
develop
to
release/wallet-mobile/v4.27.0
banklesss
force-pushed
the
fix/wallet-setup/duplicated-wallet-warning
branch
from
e00c428 to
ea96c25
Compare
|
hey @banklesss few comments, there is ticket tho for the safe area view (guess), bottom padding. |
done |
banklesss
force-pushed
the
fix/wallet-setup/duplicated-wallet-warning
branch
from
53a9b05 to
ed285fa
Compare
|
@banklesss can you fix the conflicts? |
done @stackchain |
renaming need fix too, @banklesss I think before launching the create and restore funnel, the current wallet must be closed. |
|
@stackchain fixed |
stackchain
approved these changes
Apr 17, 2024
49 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: