Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(portfolio): base sync portfolio #3195

Merged
merged 13 commits into from
Apr 15, 2024
Merged

chore(portfolio): base sync portfolio #3195

merged 13 commits into from
Apr 15, 2024

Conversation

stackchain
Copy link
Member

No description provided.

@github-actions github-actions bot added the chore label Apr 14, 2024
@stackchain stackchain force-pushed the chore/package-portfolio branch from c2f7bf0 to 704f0e9 Compare April 14, 2024 21:56
@stackchain stackchain force-pushed the chore/package-portfolio branch from e0859f2 to e319145 Compare April 14, 2024 23:00
@stackchain stackchain marked this pull request as ready for review April 15, 2024 07:59
michaeljscript
michaeljscript reviewed Apr 15, 2024
View reviewed changes
apps/wallet-mobile/scripts/create-mocked-token-infos.js Outdated Show resolved Hide resolved
apps/wallet-mobile/scripts/create-mocked-token-infos.js Outdated Show resolved Hide resolved
apps/wallet-mobile/src/features/Portfolio/common/usePortfolioBalanceManager.ts Show resolved Hide resolved
apps/wallet-mobile/src/yoroi-wallets/auth/auth.ts Outdated Show resolved Hide resolved
apps/wallet-mobile/src/yoroi-wallets/cardano/transactionManager/transactionManager.test.ts Outdated Show resolved Hide resolved
packages/portfolio/src/validators/primary-balance-breakdown.ts Show resolved Hide resolved
packages/types/src/api/cache.ts Show resolved Hide resolved
packages/types/src/portfolio/info.ts Show resolved Hide resolved
packages/portfolio/src/validators/token-type.ts Outdated Show resolved Hide resolved
packages/portfolio/src/validators/token-property-type.ts Outdated Show resolved Hide resolved
stackchain and others added 10 commits April 15, 2024 12:53
@stackchain
Update apps/wallet-mobile/scripts/create-mocked-token-infos.js
2aded1a 
Signed-off-by: Juliano Lazzarotto <[email protected]>
@stackchain
chore(wallet-mobile): CRs - dropped null from auth-settings
3e3c887
@stackchain
fix(wallet-mobile): CRs - tests
743de9c
@stackchain
refactor(wallet-mobile): CRs refactor deserializer
9591373
@stackchain @michaeljscript
Update packages/portfolio/src/adapters/dullahan-api/transformers.ts
bd716cf 
Co-authored-by: Michal S <[email protected]>
Signed-off-by: Juliano Lazzarotto <[email protected]>
@stackchain @michaeljscript
Update apps/wallet-mobile/src/yoroi-wallets/memos/memosManager.ts
e54c2c2 
Co-authored-by: Michal S <[email protected]>
Signed-off-by: Juliano Lazzarotto <[email protected]>
@stackchain
refactor(portfolio): CRs moved from .then to async for consistency
75f9768
@stackchain
refactor(portfolio): CRs leverage the utils for validators
0d49d42
@stackchain
refactor(common): CRs fix example
9d9d8c1
@stackchain
refactor(common): CRs reading
e31145d
@stackchain stackchain merged commit 749f8ea into develop Apr 15, 2024
2 checks passed
@stackchain stackchain deleted the chore/package-portfolio branch April 15, 2024 23:05
@stackchain stackchain mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljscript michaeljscript michaeljscript approved these changes

@vsubhuman vsubhuman Awaiting requested review from vsubhuman

@DoctorMarshall DoctorMarshall Awaiting requested review from DoctorMarshall

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stackchain @michaeljscript