-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(theme): themes flexibility #3196
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackchain
changed the title
refactor(theme): themes flex
refactor(theme): themes flexibility
Apr 15, 2024
@SorinC6 can you take it from here? It will require an update on wallet-mobile, big one.
It could also export from Theme the atoms, yet, IMHO is an overkill, unless is planned a |
@SorinC6 please check with Design, if they approve the Base->Theme palette naming convention we can go on with the implementation |
nistadev
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-
to_
so it can be accesseduseTheme
is designed to manage theme selection not to be consumed by the UIuseThemeColor
is designed to consume colorsIt is using
as const
therefore making the properties read-only I'm guessing react-native will complain, it can leverageWritable
or Draft from 'immer'