Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet-mobile): Non sticky max address message #3202

Merged
merged 4 commits into from
Apr 17, 2024
Merged

fix(wallet-mobile): Non sticky max address message #3202

merged 4 commits into from
Apr 17, 2024

Conversation

rahulnr7
Copy link
Contributor

@rahulnr7 rahulnr7 commented Apr 16, 2024 •
edited by jira bot
Loading

Fixes YOMO-1292

Below cases were handled

  1. Limit was just reached - the message is displayed at the top of the current view regardless of the current scroll position. If user scrolls from this position, message disappears and can see it again if scrolls all the way up.
  2. Limit already reached and user enters receive funnel - the message is displayed on the top and if user scrolls down it disappears and if user scrolls back all the way up, the message reappears

@rahulnr7 rahulnr7 requested a review from michaeljscript April 16, 2024 17:27
@github-actions github-actions bot added the fix label Apr 16, 2024
@rahulnr7 rahulnr7 requested a review from stackchain April 16, 2024 17:27
@rahulnr7 rahulnr7 added this to the 4.26.0 milestone Apr 16, 2024
@stackchain stackchain merged commit 3ca0398 into release/wallet-mobile/v4.26.0 Apr 17, 2024
2 checks passed
@stackchain stackchain deleted the fix/non-sticky-max-addrs-msg branch April 17, 2024 08:45
@stackchain stackchain mentioned this pull request Apr 17, 2024
Merged
stackchain pushed a commit that referenced this pull request May 16, 2024
@rahulnr7 @stackchain
fix(wallet-mobile): Non sticky max address message (#3202)
c71da4b
@stackchain stackchain mentioned this pull request May 16, 2024
Merged
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stackchain stackchain stackchain approved these changes

@michaeljscript michaeljscript Awaiting requested review from michaeljscript

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
4.26.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rahulnr7 @stackchain