Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dapp-connector): Add CIP-30 signData support #3280

Merged
merged 18 commits into from
Jun 7, 2024

Conversation

michaeljscript
Copy link
Collaborator

@michaeljscript michaeljscript commented Jun 3, 2024

Description / Change(s) / Related issue(s)

Implements CIP-30 signData using @emurgo/msl-mobile-bridge.

After some consideration I've decided to use @emurgo/msl-mobile-bridge instead of Dullahan (https://github.com/Emurgo/dullahan) implementation, for the following reasons

  • Dullahan is not yet published on npm and hereby would require us to copy the implementation into yoroi and later maintain the implementation
  • Copy of Dullahan implementation would require us to install and manage new dependencies, such as @noble/hashes or @noble/curves
  • It would not be only a copy and the solution would require many changes to fit our needs
  • Usage of @emurgo/msl-mobile-bridge seems more straightforward (similar to what on extension is used with @emurgo/cardano-message-signing-browser)

The below mentioned iOS issue in https://github.com/Emurgo/msl-mobile-bridge is already resolved.

Ticket

YOMO-1447

@michaeljscript michaeljscript changed the title feat(dapp-connector): CIP-30 signData WIP feat(dapp-connector): CIP-30 signData Jun 3, 2024
@michaeljscript michaeljscript self-assigned this Jun 3, 2024
@michaeljscript
Copy link
Collaborator Author

michaeljscript commented Jun 6, 2024

May need https://github.com/Emurgo/msl-mobile-bridge/pull/1 to be merged before this PR is ready to fix iOS build issues.

@michaeljscript
Copy link
Collaborator Author

After some consideration I've decided to use @emurgo/msl-mobile-bridge instead of Dullahan (https://github.com/Emurgo/dullahan) implementation, for the following reasons

  • Dullahan is not yet published on npm and hereby would require us to copy the implementation into yoroi and later maintain the implementation
  • Copy of Dullahan implementation would require us to install and manage new dependencies, such as @noble/hashes or @noble/curves
  • It would not be only a copy and the solution would require many changes to fit our needs
  • Usage of @emurgo/msl-mobile-bridge seems more straightforward (similar to what on extension is used with @emurgo/cardano-message-signing-browser)

The above mentioned iOS issue in https://github.com/Emurgo/msl-mobile-bridge is already resolved.

@michaeljscript michaeljscript changed the title WIP feat(dapp-connector): CIP-30 signData eat(dapp-connector): CIP-30 signData Jun 7, 2024
@michaeljscript michaeljscript changed the title eat(dapp-connector): CIP-30 signData feat(dapp-connector): Add CIP-30 signData support Jun 7, 2024
@michaeljscript michaeljscript marked this pull request as ready for review June 7, 2024 09:46
@michaeljscript michaeljscript requested a review from banklesss June 7, 2024 09:47
@michaeljscript michaeljscript added this to the 4.28.0 milestone Jun 7, 2024
@stackchain stackchain merged commit 6ab76fb into develop Jun 7, 2024
2 checks passed
@stackchain stackchain deleted the feat/cip-30-sign-data branch June 7, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants