Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wallet-mobile): impl explorers v1.0.1 #3553

Merged
merged 11 commits into from
Aug 22, 2024

Conversation

stackchain
Copy link
Member

@stackchain stackchain commented Aug 22, 2024

Description / Change(s) / Related issue(s)

  • chore(explorers): updated the docs
  • chore(explorers): added preview network
  • chore(explorers): bumped pkg version to 1.0.1
  • chore(types): added support to preview
  • chore(types): added stake url to network-manager
  • chore(wallet-mobile): impl explorers v1.0.1

@stackchain stackchain marked this pull request as ready for review August 22, 2024 14:47
@stackchain stackchain marked this pull request as draft August 22, 2024 14:48
@stackchain stackchain marked this pull request as ready for review August 22, 2024 15:24
@@ -12,9 +12,11 @@ import {WalletFactory} from '../../common/types'
const ShelleyWalletMainnet = makeCardanoWallet(networkManagers[Chain.Network.Mainnet], 'cardano-cip1852', MAINNET)
const ShelleyWalletTestnet = makeCardanoWallet(networkManagers[Chain.Network.Preprod], 'cardano-cip1852', TESTNET)
const ShelleySanchonetWallet = makeCardanoWallet(networkManagers[Chain.Network.Sancho], 'cardano-cip1852', SANCHONET)
const ShelleyPreviewWallet = makeCardanoWallet(networkManagers[Chain.Network.Preview], 'cardano-cip1852', SANCHONET)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old SANCHONET config will be dropped in favor of full use of network manager.

const ByronWallet = makeCardanoWallet(networkManagers[Chain.Network.Mainnet], 'cardano-bip44', MAINNET)
const ByronWalletTestnet = makeCardanoWallet(networkManagers[Chain.Network.Preprod], 'cardano-bip44', TESTNET)
const ByronSanchonetWallet = makeCardanoWallet(networkManagers[Chain.Network.Sancho], 'cardano-bip44', SANCHONET)
const ByronPreviewWallet = makeCardanoWallet(networkManagers[Chain.Network.Preview], 'cardano-bip44', SANCHONET)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ibid idem

@stackchain stackchain merged commit de1145a into develop Aug 22, 2024
2 checks passed
@stackchain stackchain deleted the refactor/network-manager branch August 22, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants