Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(governance): missing info link #3559

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix(governance): missing info link #3559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/wallet-mobile/src/components/ConfirmTxWithHwModal/ConfirmTxWithHwModal.tsx
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

improvements

Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ const ConfirmTxWithHwModalContent = ({
walletManager.updateWalletHWDeviceInfo(meta.id, hwDeviceInfo)

const isCIP1694Supported = await wallet.ledgerSupportsCIP1694(false, hwDeviceInfo)
if (!isCIP1694Supported) {
onNotSupportedCIP1694?.()
if (!isCIP1694Supported && onNotSupportedCIP1694) {
onNotSupportedCIP1694()
return
}

Expand All @@ -122,8 +122,8 @@ const ConfirmTxWithHwModalContent = ({
walletManager.updateWalletHWDeviceInfo(meta.id, hwDeviceInfo)

const isCIP1694Supported = await wallet.ledgerSupportsCIP1694(true, hwDeviceInfo)
if (!isCIP1694Supported) {
onNotSupportedCIP1694?.()
if (!isCIP1694Supported && onNotSupportedCIP1694) {
onNotSupportedCIP1694()
return
}

Expand Down
10 changes: 8 additions & 2 deletions apps/wallet-mobile/src/features/Staking/Governance/useCases/NoFunds/NoFundsScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ import {Chain} from '@yoroi/types'
import React from 'react'
import {Linking, StyleSheet, View} from 'react-native'

import {Button, Text} from '../../../../../components'
import {Button, Spacer, Text} from '../../../../../components'
import {SafeArea} from '../../../../../components/SafeArea'
import {Space} from '../../../../../components/Space/Space'
import {TxHistoryRouteNavigation} from '../../../../../kernel/navigation'
import {useWalletManager} from '../../../../WalletManager/context/WalletManagerProvider'
import {useStrings} from '../../common'
import {LearnMoreLink, useStrings} from '../../common'
import {NoFunds} from '../../illustrations'

export const NoFundsScreen = () => {
Expand Down Expand Up @@ -39,6 +39,8 @@ export const NoFundsScreen = () => {
return (
<SafeArea style={styles.root}>
<View style={styles.center}>
<Spacer height={120} />

<NoFunds />

<Space height="lg" />
Expand All @@ -48,6 +50,10 @@ export const NoFundsScreen = () => {
<Space height="lg" />

<Button title={buttonText} textStyles={styles.button} shelleyTheme onPress={handleOnTryAgain} />

<Spacer fill />

<LearnMoreLink />
</View>
</SafeArea>
)
Expand Down
Loading