Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(restore): duplicated wallet feature and plate display #3590

Merged
merged 10 commits into from
Sep 4, 2024
Merged

fix(restore): duplicated wallet feature and plate display #3590

merged 10 commits into from
Sep 4, 2024

Conversation

banklesss
Copy link
Contributor

@banklesss banklesss commented Sep 2, 2024 •
edited
Loading

Description / Change(s) / Related issue(s)

Adding:

  • missing duplicated wallet action on restore hw wallet
  • correct display of hw wallet plate on restore hw wallet
Ticket

YOMO-1886
YOMO-1884

@banklesss banklesss self-assigned this Sep 2, 2024
@github-actions github-actions bot added the fix label Sep 2, 2024
@banklesss banklesss requested a review from stackchain September 3, 2024 11:48
@banklesss banklesss requested a review from stackchain September 3, 2024 14:08
stackchain
stackchain reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@stackchain stackchain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last points and I think is real good. (there is this misconception that we validate the wallet, but instead we check if the account was already added)

@banklesss
Copy link
Contributor Author

ast points and I think is real good. (there is this misconception that we validate the wallet, but instead we check if the account was already added)

yeah it makes total sense

@banklesss banklesss requested a review from stackchain September 3, 2024 15:22
stackchain
stackchain reviewed Sep 3, 2024
View reviewed changes
apps/wallet-mobile/src/features/SetupWallet/useCases/RestoreWallet/RestoreWalletScreen.tsx Outdated
Comment on lines 115 to 117
const duplicatedAccountWalletMeta = Array.from(walletManager.walletMetas.values()).find(
(walletMeta) => walletMeta.plate === plate,
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happens inside wallet.isWalletAccountDuplicated

Suggested change
const duplicatedAccountWalletMeta = Array.from(walletManager.walletMetas.values()).find(
(walletMeta) => walletMeta.plate === plate,
)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case we need to get the specific wallet meta to display the info

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some

Here is find

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applied a refactor

252d95b

@banklesss banklesss requested a review from stackchain September 3, 2024 16:17
@stackchain stackchain merged commit 583d107 into develop Sep 4, 2024
2 checks passed
@stackchain stackchain deleted the fix/restore-hw-wallet branch September 4, 2024 06:42
@stackchain stackchain mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljscript michaeljscript michaeljscript approved these changes

@jorbuedo jorbuedo Awaiting requested review from jorbuedo

@stackchain stackchain Awaiting requested review from stackchain

Assignees

@banklesss banklesss

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@banklesss @michaeljscript @stackchain