feat(wallet-mobile): send feature new tx review #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorbuedo
reviewed
Sep 20, 2024
apps/wallet-mobile/src/features/Send/useCases/ConfirmTx/ConfirmTxScreen.tsx
Outdated
Show resolved
Hide resolved
jorbuedo
reviewed
Sep 20, 2024
jorbuedo
reviewed
Sep 20, 2024
|
|
||
| <SenderTokens tx={tx} notOwnedOutputs={notOwnedOutputs} /> | ||
|
|
||
| {notOwnedOutputs.length === 1 && <ReceiverSection notOwnedOutputs={notOwnedOutputs} />} |
There was a problem hiding this comment.
Is it intended when sending assets to yourself (maybe to reorganize utxos) to not show a receiving side?
There was a problem hiding this comment.
its specified in this way https://figma.com/design/KeBVo6rWNYFLXwTphz9lHi/Mobile-App?node-id=26010-28671&node-type=shape_with_text&m=dev
In my personal opinion it makes sense because you are just paying the fee and it is reflected on that screen.
Good point anyway.
banklesss
commented
Sep 22, 2024
apps/wallet-mobile/src/features/ReviewTx/common/hooks/useAddressType.tsx
Outdated
Show resolved
Hide resolved
…ssType.tsx Signed-off-by: banklesss <[email protected]>
banklesss
commented
Sep 22, 2024
apps/wallet-mobile/src/features/ReviewTx/common/hooks/useFormattedTx.tsx
Outdated
Show resolved
Hide resolved
…ttedTx.tsx Signed-off-by: banklesss <[email protected]>
banklesss
commented
Sep 22, 2024
apps/wallet-mobile/src/features/ReviewTx/common/hooks/useFormattedTx.tsx
Outdated
Show resolved
Hide resolved
…ttedTx.tsx Signed-off-by: banklesss <[email protected]>
…d funnel" This reverts commit 81d472e.
…d funnel" This reverts commit daecf73.
apps/wallet-mobile/src/features/ReviewTx/useCases/ReviewTxScreen/Overview/OverviewTab.tsx
Show resolved
Hide resolved
stackchain
reviewed
Sep 23, 2024
apps/wallet-mobile/src/features/ReviewTx/useCases/ReviewTxScreen/UTxOs/UTxOsTab.tsx
Outdated
Show resolved
Hide resolved
stackchain
reviewed
Sep 23, 2024
apps/wallet-mobile/src/features/ReviewTx/useCases/ReviewTxScreen/UTxOs/UTxOsTab.tsx
Outdated
Show resolved
Hide resolved
stackchain
changed the title
1 task
stackchain
reviewed
Oct 10, 2024
stackchain
reviewed
Oct 10, 2024
Co-authored-by: Juliano Lazzarotto <[email protected]> Signed-off-by: banklesss <[email protected]>
Co-authored-by: Juliano Lazzarotto <[email protected]> Signed-off-by: banklesss <[email protected]>
stackchain
approved these changes
Oct 10, 2024
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Change(s) / Related issue(s)
Covering send funnel with the new tx review
Ticket
YOMO-1934