Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet-mobile): dev builds automatically invalidate token image on error #3652

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

jorbuedo
Copy link
Contributor

@jorbuedo jorbuedo commented Sep 23, 2024

Description / Change(s) / Related issue(s)

Seems like a bad thing to do in prod, but should be fine to clear out failing images during dev and qa.

related https://emurgo.atlassian.net/browse/YOMO-1920

@jorbuedo jorbuedo added the proposal Feature proposal for triage. Required for non-trivial features. label Sep 23, 2024
@jorbuedo jorbuedo self-assigned this Sep 23, 2024
@stackchain
Copy link
Member

I think is a very good idea for prod too.

@stackchain stackchain merged commit 8c48e57 into develop Sep 24, 2024
3 checks passed
@stackchain stackchain deleted the dev-token-img-invalidation branch September 24, 2024 10:22
@jorbuedo
Copy link
Contributor Author

@stackchain there's images that simply will never work, because there's no image. Having thousands of clients spamming invalidate seems wasteful.

@stackchain
Copy link
Member

@stackchain there's images that simply will never work, because there's no image. Having thousands of clients spamming invalidate seems wasteful.

yap :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Feature proposal for triage. Required for non-trivial features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants