refactor(wallet-mobile): display native kb for device pin #3653
+78
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorbuedo
added
the
proposal
|
@jorbuedo Thanks for checking it. I tried an experiment based on your comments for using the hidden text inputs. The native kb does show up but looks like it is not consistent. I will try further to improve it. Here is a recording from iOS how it works. Uploading Simulator Screen Recording - iPhone11 - 2024-09-24 at 15.54.37.mp4… |
|
|
stackchain
reviewed
Sep 24, 2024
stackchain
reviewed
Sep 24, 2024
stackchain
reviewed
Sep 24, 2024
apps/wallet-mobile/src/features/Auth/CreatePinInput/CreatePinInput.tsx
Outdated
Show resolved
Hide resolved
stackchain
reviewed
Sep 24, 2024
apps/wallet-mobile/src/features/Auth/CreatePinInput/CreatePinInput.tsx
Outdated
Show resolved
Hide resolved
stackchain
reviewed
Sep 24, 2024
stackchain
reviewed
Sep 24, 2024
stackchain
reviewed
Sep 24, 2024
stackchain
reviewed
Sep 24, 2024
|
I don't like that in Android you can close the keyboard and then not have how to open it again. |
|
@jorbuedo Yeah that seems to be an issue that I might need time to research. As this is earmarked for 5.1, will try again after closing the pending bugs. Thanks. |
stackchain
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
display native kb for device pin
Ticket
YOMO-1893
Note
Please create the ticket if missing it.