Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet-mobile): remove duplicate title #3657

Merged
merged 7 commits into from
Sep 25, 2024
Merged

Conversation

jorbuedo
Copy link
Contributor

@jorbuedo jorbuedo commented Sep 25, 2024

Description / Change(s) / Related issue(s)

Ticket

YOMO-1899

@jorbuedo jorbuedo requested a review from rahulnr7 September 25, 2024 09:46
@rahulnr7
Copy link
Contributor

rahulnr7 commented Sep 25, 2024

@jorbuedo the button label for disabled USB has default message with !!!.

@stackchain
Copy link
Member

USB should be listed only for Android, on iOS is not possible to use USB.

@rahulnr7
Copy link
Contributor

Please note the '!!!' chars before the 'Connect with USB'

@stackchain
Copy link
Member

Please note the '!!!' chars before the 'Connect with USB'

Yap it means that the translation key was not found.

@rahulnr7
Copy link
Contributor

Also had to revert this change to fix below issue

@jorbuedo
Copy link
Contributor Author

Ok

@stackchain stackchain merged commit cf6c8fd into develop Sep 25, 2024
2 checks passed
@stackchain stackchain deleted the yomo-1899-fix branch September 25, 2024 23:15
@jorbuedo jorbuedo self-assigned this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants