Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(wallet-mobile): Button, IconProps, useCopy #3658

Merged
merged 20 commits into from
Oct 11, 2024
Merged

Conversation

jorbuedo
Copy link
Contributor

@jorbuedo jorbuedo commented Sep 26, 2024

Description / Change(s) / Related issue(s)

Ticket

YOMO-1938

https://www.figma.com/design/cnvVqO3XxEPNFyE5qE1j2s/Components---Mobile?node-id=2065-18310&node-type=frame&t=OPYP3NRW5kwfsQgQ-0

Relevant bits:

  • apps/wallet-mobile/src/components/Button/Button.tsx
  • apps/wallet-mobile/src/components/Clipboard/ClipboardProvider.tsx
  • apps/wallet-mobile/src/components/CopyButton.tsx

Will need QA review due to how many there are, but seem fine from what I've seen:

  • Icons sizes and colors
  • Buttons sizes, colors and positions
  • Click to copy buttons and fields

@jorbuedo jorbuedo added wip Shows that a PR shouldn't be merge refactor labels Sep 26, 2024
@jorbuedo jorbuedo added this to the 5.1.0 "Notify me" milestone Sep 26, 2024
@jorbuedo jorbuedo self-assigned this Sep 26, 2024
@jorbuedo jorbuedo changed the title refactor(wallet-mobile): Button and useCopy refactor(wallet-mobile): Button, IconProps, useCopy Sep 26, 2024
@jorbuedo jorbuedo requested review from stackchain, banklesss, rahulnr7 and michaeljscript and removed request for stackchain September 26, 2024 13:38
@jorbuedo jorbuedo removed the wip Shows that a PR shouldn't be merge label Sep 26, 2024
@jorbuedo jorbuedo marked this pull request as ready for review September 26, 2024 13:38
@stackchain
Copy link
Member

@jorbuedo can you tackle the conflicts?

@stackchain stackchain merged commit 7376022 into develop Oct 11, 2024
2 checks passed
@stackchain stackchain deleted the yomo-1938 branch October 11, 2024 10:13
@stackchain stackchain mentioned this pull request Dec 5, 2024
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants