Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet-mobile): offline crashes #3664

Merged
merged 6 commits into from
Oct 15, 2024
Merged

fix(wallet-mobile): offline crashes #3664

merged 6 commits into from
Oct 15, 2024

Conversation

jorbuedo
Copy link
Contributor

@jorbuedo jorbuedo commented Sep 30, 2024

Description / Change(s) / Related issue(s)

Ticket

YOMO-1944

@jorbuedo jorbuedo added the fix label Sep 30, 2024
@jorbuedo jorbuedo requested a review from stackchain September 30, 2024 15:31
@jorbuedo jorbuedo self-assigned this Sep 30, 2024
@jorbuedo jorbuedo added this to the 5.0.0 "Day & Night" milestone Sep 30, 2024
@stackchain stackchain marked this pull request as draft October 10, 2024 09:39
@jorbuedo
Copy link
Contributor Author

@stackchain I assume you don't like this one because it's a provisional solution and those api shouldn't throw in the first place? Offline support isn't expected yet, but at least not crashing would be an improvement.

@stackchain
Copy link
Member

@stackchain I assume you don't like this one because it's a provisional solution and those api shouldn't throw in the first place? Offline support isn't expected yet, but at least not crashing would be an improvement.

I believe the issue here is structural on Yoroi, so the problem is deeper, I'd like to avoid short fixes, so far no user has complained about it, I believe these days no one is using it offline, so I'd like to plan this change after 0.74/0.75/0.76 bump.

@stackchain
Copy link
Member

@stackchain I assume you don't like this one because it's a provisional solution and those api shouldn't throw in the first place? Offline support isn't expected yet, but at least not crashing would be an improvement.

I believe the issue here is structural on Yoroi, so the problem is deeper, I'd like to avoid short fixes, so far no user has complained about it, I believe these days no one is using it offline, so I'd like to plan this change after 0.74/0.75/0.76 bump.

Yet, leave this one open, considering to include on 5.1, since a lot of focus on Anzens, maybe the bump will get delayed.

@stackchain stackchain marked this pull request as ready for review October 15, 2024 13:16
@stackchain stackchain merged commit ea153f9 into develop Oct 15, 2024
2 checks passed
@stackchain stackchain mentioned this pull request Dec 5, 2024
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants