feature(wallet-mobile): new tx review for collateral #3683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tx-review-token-details
banklesss
force-pushed
the
feature/tx-review-collateral
branch
from
d15e481 to
e017a6d
Compare
banklesss
force-pushed
the
feature/tx-review-collateral
branch
from
e017a6d to
b7f710f
Compare
banklesss
commented
Oct 8, 2024
Comment on lines
+107
to
+108
| onSuccessChanged(onSuccess) | ||
| onErrorChanged(onError) |
There was a problem hiding this comment.
onError and onSuccess variables will be removed when product designs common screens
banklesss
commented
Oct 8, 2024
Comment on lines
+97
to
+99
| operationsChanged([<Operation key="0" />]) | ||
| onSuccessChanged(onSuccess) | ||
| onErrorChanged(onError) |
There was a problem hiding this comment.
onError and onSuccess variables will be removed when product designs common screens
The operations are very specific for each screen so I have decided to make them dependent on the screen that uses tx review
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Change(s) / Related issue(s)
Add new tx review for collateral funnel
Ticket
YV-36