Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wallet-mobile): Bump CSL #3685

Merged
merged 14 commits into from
Oct 23, 2024
Merged

chore(wallet-mobile): Bump CSL #3685

merged 14 commits into from
Oct 23, 2024

Conversation

michaeljscript
Copy link
Collaborator

@michaeljscript michaeljscript commented Oct 11, 2024

Description / Change(s) / Related issue(s)

todo:

  • Add check for HW wallets for TXs generated by DApps
  • Update yoroi lib
  • Update CSL
  • Verify local build
Ticket

YV-39

@github-actions github-actions bot added the chore label Oct 11, 2024
@michaeljscript
Copy link
Collaborator Author

looking into yoroi-lib

@michaeljscript
Copy link
Collaborator Author

michaeljscript commented Oct 22, 2024

Tested on muesliswap with HW wallet, TX went through. https://cardanoscan.io/transaction/7bb2f5cce134053d103d10cdf2b04c5119cfb3f3d5bd140fb39afa19b32dacfd

@michaeljscript michaeljscript marked this pull request as ready for review October 22, 2024 20:01
@michaeljscript michaeljscript changed the title WIP chore(wallet-mobile): Bump CSL chore(wallet-mobile): Bump CSL Oct 22, 2024
@michaeljscript
Copy link
Collaborator Author

After merging this PR, we may need a full regression test

@@ -63,8 +65,13 @@ export const ReviewTransaction = () => {
return
}

const signature = await signTxWithHW(params.cbor, params.partial)
params.onConfirm(signature)
signTxWithHW(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@banklesss I'm guessing u r moving it to the new funnel, this will break ur changes

Copy link
Member

@stackchain stackchain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stackchain stackchain merged commit 1bb2adc into develop Oct 23, 2024
2 checks passed
@stackchain stackchain deleted the chore/csl-update-13 branch October 23, 2024 08:22
@stackchain stackchain added this to the 5.1.0 "Notify me" milestone Oct 23, 2024
@stackchain stackchain mentioned this pull request Dec 5, 2024
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants