-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(wallet-mobile): Bump CSL #3685
Conversation
looking into yoroi-lib |
Tested on muesliswap with HW wallet, TX went through. https://cardanoscan.io/transaction/7bb2f5cce134053d103d10cdf2b04c5119cfb3f3d5bd140fb39afa19b32dacfd |
After merging this PR, we may need a full regression test |
@@ -63,8 +65,13 @@ export const ReviewTransaction = () => { | |||
return | |||
} | |||
|
|||
const signature = await signTxWithHW(params.cbor, params.partial) | |||
params.onConfirm(signature) | |||
signTxWithHW( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@banklesss I'm guessing u r moving it to the new funnel, this will break ur changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description / Change(s) / Related issue(s)
todo:
Ticket
YV-39