feature(wallet-mobile): new tx review for withdraw staking rewards #3707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banklesss
commented
Oct 24, 2024
Merged
jorbuedo
approved these changes
Oct 24, 2024
stackchain
reviewed
Oct 24, 2024
| @@ -152,6 +168,7 @@ type ReviewTxActions = { | |||
| onErrorChanged: (onError: ReviewTxState['onError']) => void | |||
There was a problem hiding this comment.
is not a good idea to have objects that are not serializable in the state, (eg. if we decide to leverage persisted state this will fail), and context also can quickly become a problem
There was a problem hiding this comment.
Yeah. It is a temporal solution until the common error screens are implemented
|
@banklesss bring it in, but create a task to remove all callbacks out of the state. |
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Change(s) / Related issue(s)
New tx review for withdraw staking rewards feature.
Includes a operations refactor.
Ticket
YV-41