Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dapp-connector): Prompt user only if window is focused and fix error handling #3722

Merged
merged 7 commits into from
Nov 5, 2024

Conversation

michaeljscript
Copy link
Collaborator

@michaeljscript michaeljscript commented Nov 5, 2024

Description / Change(s) / Related issue(s)

Prompt user only if window is focused

Ticket

YV-82

@github-actions github-actions bot added the fix label Nov 5, 2024
@michaeljscript michaeljscript marked this pull request as ready for review November 5, 2024 09:51
@michaeljscript michaeljscript self-assigned this Nov 5, 2024
@michaeljscript michaeljscript marked this pull request as draft November 5, 2024 10:19
@michaeljscript michaeljscript changed the title fix(dapp-connector): Prompt user only if window is focused WIP fix(dapp-connector): Prompt user only if window is focused Nov 5, 2024
@michaeljscript michaeljscript changed the title WIP fix(dapp-connector): Prompt user only if window is focused WIP fix(dapp-connector): Prompt user only if window is focused and fix error handling Nov 5, 2024
@michaeljscript michaeljscript marked this pull request as ready for review November 5, 2024 10:47
@michaeljscript michaeljscript changed the title WIP fix(dapp-connector): Prompt user only if window is focused and fix error handling fix(dapp-connector): Prompt user only if window is focused and fix error handling Nov 5, 2024
@stackchain stackchain added this to the 5.2.0 "Inspector Gadget" milestone Nov 5, 2024
@stackchain stackchain merged commit d79a936 into develop Nov 5, 2024
1 check passed
@stackchain stackchain deleted the fix/user-rejected branch November 5, 2024 12:43
@stackchain stackchain mentioned this pull request Dec 5, 2024
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants