fix(wallet-mobile): cbor wasnt cleaned after use #3738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banklesss
changed the base branch from
develop
to
feature/new-tx-review-update-operations
michaeljscript
approved these changes
Nov 14, 2024
stackchain
approved these changes
Nov 14, 2024
stackchain
merged commit a55b6ce
into
feature/new-tx-review-update-operations
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cbor was not cleaned up so when making a new transaction using unsigned tx the transactions were mixed
The use of unsigned tx and the provider is deprecated: it is still used because during catalyst registration unsigned tx can change due to CIP36. THE GOAL IS TO ELIMINATE THE USE OF UNSIGNED TX IN THE NEAR FUTURE💥💥💥💥💥