Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet-mobile): Allow ledger to withdraw from non own address #3763

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

fix(wallet-mobile): Allow ledger to withdraw from non own address #3763

wants to merge 1 commit into from
+31 −11

Conversation

michaeljscript
Copy link
Collaborator

@michaeljscript michaeljscript commented Dec 13, 2024 •
edited by jira bot
Loading

Description / Change(s) / Related issue(s)

Ticket

YV-161

@github-actions github-actions bot added the fix label Dec 13, 2024
@michaeljscript
Copy link
Collaborator Author

michaeljscript commented Dec 13, 2024 •
edited
Loading

When withdrawing from non own address, should the dApp call signTx(cbor, partial) where partial = true?

@michaeljscript michaeljscript self-assigned this Dec 13, 2024
@michaeljscript michaeljscript added wip Shows that a PR shouldn't be merge dont-merge labels Dec 13, 2024
@michaeljscript
Copy link
Collaborator Author

There are some issues with own address detection. WIP

@michaeljscript michaeljscript marked this pull request as draft December 13, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stackchain stackchain Awaiting requested review from stackchain

@jorbuedo jorbuedo Awaiting requested review from jorbuedo

@vsubhuman vsubhuman Awaiting requested review from vsubhuman

@banklesss banklesss Awaiting requested review from banklesss

At least 1 approving review is required to merge this pull request.

Assignees

@michaeljscript michaeljscript

Labels
dont-merge fix wip Shows that a PR shouldn't be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michaeljscript