Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions workflow for code checks #11

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Conversation

InensusDev
Copy link
Contributor

No description provided.

@InensusDev InensusDev requested a review from dmohns November 27, 2023 09:58
Copy link
Member

@dmohns dmohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is in the wrong location. Can you move it to .github/workflows/check.yml so it runs on this Pull Request and we can see some results?

@InensusDev InensusDev requested a review from dmohns November 29, 2023 08:43
@dmohns
Copy link
Member

dmohns commented Nov 29, 2023

Right now we are adding a single job that runs all the linter. Could you split the build pipeline into multiple ones, one per linter?

For example, currently your CI yaml looks (a little simplified) like this:

jobs:
  build:
    - Lint ESLint JS
    - Lint ESLint Vue
    - Lint PHP
    - Run`npm build`    

Could you change it to be more like this:

jobs:
  lint-eslint-js:
    - Lint ESLint JS
  lint-eslint-vue:
    - Lint ESLint Vue
  lint-php:
    - Lint PHP
  build:
    - Run`npm build`    

This way they can all run in parallel and don't get blocked if one of them fails.

@alchalade alchalade force-pushed the standards-enforcement branch 2 times, most recently from 0b85974 to f2f561c Compare December 1, 2023 14:55
@alchalade alchalade force-pushed the standards-enforcement branch from f2f561c to 22fd9ba Compare December 1, 2023 14:59
@alchalade alchalade merged commit 24393bb into main Dec 1, 2023
4 of 5 checks passed
@alchalade alchalade deleted the standards-enforcement branch December 1, 2023 18:25
@alchalade alchalade restored the standards-enforcement branch December 1, 2023 18:25
@alchalade alchalade deleted the standards-enforcement branch December 1, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants