(infra) Remove composer container and let laravel container install d…

[alchalade]

#25

The laravel conitainer explicitly installs the soap extension in order to use the soapClient. After evaluating both

• "Creating a custom composer image "
• "let the laravel container install the dependencies"

I decided to go with the 2nd option as having a separate composer container has no extra value over let the main php container install the dependencies.

How to test;

• remove vendor directory
• run docker-compose up --build this should already re-build the laravel container
• expect to see the vendor directory in Website/htdocs/mpmanager/

[dmohns]

Doesn't this overwrite the CMD from the underlying Dockerfile CMD ["apache2-foreground"] ?https://hub.docker.com/layers/library/php/8.2-apache/images/sha256-39d43cc32ea91e96fa7333cd52f67b6d91c8c4b22130443db0b1ac5f26b7c738?context=explore ?

[alchalade]

@dmohns oh very good catch thank you for this 🙏 . I totally missed that one.

[dmohns]

I'm trying to run this on my local machine after deleting the vendor directory.

Running docker compose up does indeed re-create the vendor directory and I can see output of composer in the logs. However, the container exists and doesn't keep running. This isn't intended right?

[alchalade]

@dmohns TBH I didn't checked it before I pushed the 2nd change. The weird thing is that the CMD form the base image got lost even though there is nothing in between that overwrites the CMD .

The defensive check in the .sh file should do the trick now.

[dmohns]

@dmohns TBH I didn't checked it before I pushed the 2nd change. The weird thing is that the CMD form the base image got lost even though there is nothing in between that overwrites the CMD .

The defensive check in the .sh file should do the trick now.

Yepp, it works now. I will admit I don't fully understand why this happens, but that's fine 😉

LGTM

[dmohns]

Little Github hack: You can use

Closes #25

syntax for this to automatically close the linked issue, once the PR is merged 😉