Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in Company registration #354

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

dmohns
Copy link
Member

@dmohns dmohns commented Nov 18, 2024

Brief summary of the change made

This PR resolves a race condition error at the end of company sign up. After a new user's company has been registered the frontend tries to fetch the enabled plugins. However, at this point the user isn't logged in yet, so the request fails.

Moving the call to after auth/authenticate fixes the issue. It remains a mystery how this ever worked.

Are there any other side effects of this change that we should be aware of?

N/A

Describe how you tested your changes?

docker compose up

Pull Request checklist

Please confirm you have completed any of the necessary steps below.

  • Meaningful Pull Request title and description
  • Changes tested as described above
  • Added appropriate documentation for the change.
  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@dmohns dmohns merged commit e29b2e0 into main Nov 18, 2024
10 checks passed
@dmohns dmohns deleted the fix-registration-race-condition branch November 18, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant