Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ft remove bongo #260 #372

Closed

Conversation

munyanezaarmel
Copy link
Contributor

closes:#260

Brief summary of the change made

Are there any other side effects of this change that we should be aware of?

Describe how you tested your changes?

Pull Request checklist

Please confirm you have completed any of the necessary steps below.

  • Meaningful Pull Request title and description
  • Changes tested as described above
  • Added appropriate documentation for the change.
  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@dmohns
Copy link
Member

dmohns commented Nov 20, 2024

Can you also remove the Bongo leftovers from services.php ?

@dmohns dmohns requested a review from alchalade November 21, 2024 08:50
@dmohns
Copy link
Member

dmohns commented Nov 21, 2024

Hey @munyanezaarmel Looks good, change wise. However, looks like you have started this branch based on your Laravel Pint branch. Could you please rebase this branch off of main ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants