Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improv: ensure all commands that extend abscommand has company id option #379

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

beesaferoot
Copy link
Contributor

@beesaferoot beesaferoot commented Nov 23, 2024

Brief summary of the change made

With this change, all commands that extend AbstractSharedCommand propagate company-id option.

Closes: #91

Are there any other side effects of this change that we should be aware of?

Describe how you tested your changes?

Pull Request checklist

Please confirm you have completed any of the necessary steps below.

  • Meaningful Pull Request title and description
  • Changes tested as described above
  • Added appropriate documentation for the change.
  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

dmohns
dmohns previously approved these changes Nov 25, 2024
Copy link
Member

@dmohns dmohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks 👍

@dmohns
Copy link
Member

dmohns commented Nov 25, 2024

@beesaferoot could you check the failing linter?

@dmohns
Copy link
Member

dmohns commented Nov 25, 2024

Btw: Is this also directly resolving #91 ? Or are additional steps required this #91 to resolved?

@beesaferoot
Copy link
Contributor Author

Btw: Is this also directly resolving #91 ? Or are additional steps required this #91 to resolved?

This directly fixes #91, should have added this to the issue description. Sorry :)

@dmohns dmohns merged commit 78a49c3 into EnAccess:main Nov 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AbstractSharedCommand not propagating it's option to help
2 participants