Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: steps to re-deploy the demo version #381

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Delyc
Copy link
Contributor

@Delyc Delyc commented Nov 27, 2024

Brief summary of the change made

Are there any other side effects of this change that we should be aware of?

Describe how you tested your changes?

Pull Request checklist

Please confirm you have completed any of the necessary steps below.

  • Meaningful Pull Request title and description
  • Changes tested as described above
  • Added appropriate documentation for the change.
  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@Delyc Delyc marked this pull request as draft November 27, 2024 06:59
Copy link
Member

@dmohns dmohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments. Please also fix the linter

Comment on lines +9 to +17
mapUsers: |
- userarn: arn:aws:iam::905418087090:user/daniel
username: daniel
groups:
- system:masters
- userarn: arn:aws:iam::905418087090:user/yannick
username: yannick
groups:
- system:masters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we find a way to have the re-usable? I.e. without hardcoding AWS account id's and user accounts here?

@@ -0,0 +1,37 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Document steps to re-deploy the Demo version after a new release
2 participants