-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: steps to re-deploy the demo version #381
base: main
Are you sure you want to change the base?
doc: steps to re-deploy the demo version #381
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments. Please also fix the linter
mapUsers: | | ||
- userarn: arn:aws:iam::905418087090:user/daniel | ||
username: daniel | ||
groups: | ||
- system:masters | ||
- userarn: arn:aws:iam::905418087090:user/yannick | ||
username: yannick | ||
groups: | ||
- system:masters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we find a way to have the re-usable? I.e. without hardcoding AWS account id's and user accounts here?
@@ -0,0 +1,37 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brief summary of the change made
Are there any other side effects of this change that we should be aware of?
Describe how you tested your changes?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.