Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic linters #4

Merged
merged 21 commits into from
Dec 11, 2023
Merged

Add generic linters #4

merged 21 commits into from
Dec 11, 2023

Conversation

dmohns
Copy link
Member

@dmohns dmohns commented Nov 22, 2023

This PR adds basic linter Github Actions that is commonly used in our repos to this repo. Next to some smaller fixes to the existing code base to make the linters pass.

@dmohns dmohns marked this pull request as ready for review November 23, 2023 13:13
@dmohns dmohns requested a review from InensusDev November 23, 2023 13:14
@alchalade
Copy link
Contributor

alchalade commented Dec 1, 2023

@dmohns can you squash your commits, as its hard to follow them ?

@dmohns
Copy link
Member Author

dmohns commented Dec 4, 2023

Hey @alchalade

Most of the commits were added after rebases. The repositories is configured to allow only Squash&Merge anyways, so having lot of commits in a PR is not really an issue.

However, of course, if this make it easier for you to review, I can "pre-suqash" the commits on the PR already.

@dmohns
Copy link
Member Author

dmohns commented Dec 4, 2023

Had a quick look at squashing... It's gonna be a lot of effort to squash this PR prior to merge, as there are ton's of merge conflict due to how old this PR already is.

Any objections to leave this as is? Anyways the code change, as in number of lines and file changes is small.

@alchalade
Copy link
Contributor

@dmohns sure, I understand it.
Could be use rebase strategy instead of merge when bringing the feature branch on top of master/main? This will basically remove the unrelated commit history.
I'll review it in the afternoon.

@dmohns dmohns merged commit 5507467 into main Dec 11, 2023
8 checks passed
@dmohns dmohns deleted the add-generic-linter-configs branch December 11, 2023 08:34
dmohns added a commit that referenced this pull request Dec 11, 2023
After merge of #4 few whitespace issues are still left in the code base. Fixing them here.
@dmohns dmohns mentioned this pull request Dec 11, 2023
dmohns added a commit that referenced this pull request Dec 12, 2023
After merge of #4 few whitespace issues are still left in the code base. Fixing them here.
dmohns added a commit that referenced this pull request Dec 12, 2023
After merge of #4 few whitespace issues are still left in the code base. Fixing them here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants