-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic linters #4
Conversation
@dmohns can you squash your commits, as its hard to follow them ? |
Hey @alchalade Most of the commits were added after rebases. The repositories is configured to allow only Squash&Merge anyways, so having lot of commits in a PR is not really an issue. However, of course, if this make it easier for you to review, I can "pre-suqash" the commits on the PR already. |
Had a quick look at squashing... It's gonna be a lot of effort to squash this PR prior to merge, as there are ton's of merge conflict due to how old this PR already is. Any objections to leave this as is? Anyways the code change, as in number of lines and file changes is small. |
@dmohns sure, I understand it. |
After merge of #4 few whitespace issues are still left in the code base. Fixing them here.
After merge of #4 few whitespace issues are still left in the code base. Fixing them here.
After merge of #4 few whitespace issues are still left in the code base. Fixing them here.
This PR adds basic linter Github Actions that is commonly used in our repos to this repo. Next to some smaller fixes to the existing code base to make the linters pass.