Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test suite #108 #426

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix test suite #108 #426

wants to merge 7 commits into from

Conversation

beesaferoot
Copy link
Contributor

Brief summary of the change made

Are there any other side effects of this change that we should be aware of?

Describe how you tested your changes?

This PR fixes #108 and creates a github test suite workflow

Pull Request checklist

Please confirm you have completed any of the necessary steps below.

  • Meaningful Pull Request title and description
  • Changes tested as described above
  • Added appropriate documentation for the change.
  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@beesaferoot beesaferoot requested a review from dmohns December 15, 2024 22:59
@dmohns
Copy link
Member

dmohns commented Dec 16, 2024

Looks like something isn't really working here. All tests are failing with

SQLSTATE[HY000] [1045] Access denied for user 'forge'@'172.18.0.1' (using password: NO)

This suggests that it's not picking up the env variables. Can you check this?

Also, could you add instructions to the docs on how to run these tests locally, when developing the app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the Test Suite
2 participants