Fixed PR comments (sonar warnings)

Encamina · Mar 7, 2024 · 560de83 · 560de83
1 parent 4c2ab1d
commit 560de83
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/Encamina.Enmarcha.AI.Abstractions/ISemanticTextSplitter.cs b/src/Encamina.Enmarcha.AI.Abstractions/ISemanticTextSplitter.cs
@@ -10,7 +10,7 @@ public interface ISemanticTextSplitter
     /// </summary>
     /// <param name="text">The input text to be split.</param>
     /// <param name="embeddingsGenerator">A function to generate embeddings for a list of strings.</param>
-    /// <param name="cancellationToken">The <see cref="CancellationToken"/> to monitor for cancellation requests. The default is <see cref="CancellationToken.None"/>.</param>
+    /// <param name="cancellationToken">The <see cref="CancellationToken"/> to monitor for cancellation requests.</param>
     /// <returns>A collection of text splits.</returns>
-    Task<IEnumerable<string>> SplitAsync(string text, Func<IList<string>, CancellationToken, Task<IList<ReadOnlyMemory<float>>>> embeddingsGenerator, CancellationToken cancellationToken = default);
+    Task<IEnumerable<string>> SplitAsync(string text, Func<IList<string>, CancellationToken, Task<IList<ReadOnlyMemory<float>>>> embeddingsGenerator, CancellationToken cancellationToken);
 }
diff --git a/src/Encamina.Enmarcha.AI/TextSplitters/SemanticTextSplitter.cs b/src/Encamina.Enmarcha.AI/TextSplitters/SemanticTextSplitter.cs
@@ -31,7 +31,7 @@ public SemanticTextSplitter(IOptionsMonitor<SemanticTextSplitterOptions> options
     }
 
     /// <inheritdoc/>
-    public async Task<IEnumerable<string>> SplitAsync(string text, Func<IList<string>, CancellationToken, Task<IList<ReadOnlyMemory<float>>>> embeddingsGenerator, CancellationToken cancellationToken = default)
+    public async Task<IEnumerable<string>> SplitAsync(string text, Func<IList<string>, CancellationToken, Task<IList<ReadOnlyMemory<float>>>> embeddingsGenerator, CancellationToken cancellationToken)
     {
         // Code inspired by
         // https://github.com/run-llama/llama_index/blob/8ed753df970f068f6afc8a83fd51a1f40880de9e/llama-index-packs/llama-index-packs-node-parser-semantic-chunking/llama_index/packs/node_parser_semantic_chunking/base.py

diff --git a/tst/Encamina.Enmarcha.AI.Tests/SemanticTextSplitterTests.cs b/tst/Encamina.Enmarcha.AI.Tests/SemanticTextSplitterTests.cs
@@ -32,7 +32,7 @@ public async Task SplitText_Succeeds()
             });
 
         // Act...
-        var splits = (await semanticTextSplitter.SplitAsync(text, embeddingsGeneratorMock.Object)).ToList();
+        var splits = (await semanticTextSplitter.SplitAsync(text, embeddingsGeneratorMock.Object, CancellationToken.None)).ToList();
 
         // Assert...
         Assert.Equal(2, splits.Count);
@@ -50,7 +50,7 @@ public async Task SplitText_With_SingleSentence_Returns_OriginalText()
         var semanticTextSplitter = new SemanticTextSplitter(optionsMonitor);
 
         // Act...
-        var splits = (await semanticTextSplitter.SplitAsync(singleSentence, embeddingsGeneratorMock.Object)).ToList();
+        var splits = (await semanticTextSplitter.SplitAsync(singleSentence, embeddingsGeneratorMock.Object, CancellationToken.None)).ToList();
 
         // Assert...
         Assert.Single(splits);