-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling Http NotFound Exception in MemoryStoreExtender #72
Comments
LuisM000
added a commit
that referenced
this issue
Feb 8, 2024
…on_handling_#72 Temporary workaround for handling Http NotFound exception in MemoryStoreExtender
rliberoff
added a commit
that referenced
this issue
Feb 13, 2024
- Updated `Azure.AI.OpenAI` from `1.0.0-beta12` to `1.0.0-beta13` (which provides some fixes for Function Calling). - Updated `Azure.Data.Tables` from `12.8.2` to `12.8.3`. - Updated `Microsoft.Bot.Builder.Azure` from `4.22.0` to `4.22.1`. - Updated `Microsoft.Bot.Builder.Azure.Blobs` from `4.22.0` to `4.22.1`. - Updated `Microsoft.Bot.Builder.Dialogs` from `4.22.0` to `4.22.1`. - Updated `Microsoft.Bot.Builder.Integration.ApplicationInsights.Core` from `4.22.0` to `4.22.1`. - Updated `MMicrosoft.Bot.Builder.Integration.AspNet.Core` from `4.22.0` to `4.22.1`. - Updated `Microsoft.Semantic Kernel` from `1.3.0` to `1.3.1`. - Updated `Microsoft.SemanticKernel.Connectors.AzureAISearch` from `1.3.0-alpha` to `1.3.1-alpha`. **Important**: this does not fix the issue detected by ENMARCHA and reported in [Issue 72](#72). - Updated `Microsoft.SemanticKernel.Connectors.Qdrant` from `1.3.0-alpha` to `1.3.1-alpha`. - Updated `Microsoft.SemanticKernel.Plugins.Document` from `1.3.0-alpha` to `1.3.1-alpha`. - Updated `Microsoft.SemanticKernel.Plugins.Memory` from `1.3.0-alpha` to `1.3.1-alpha`. - Updated `SharpToken` from `1.2.14` to `1.2.15`.
A new version of Semantic Kernel (v.1.4.0) with the fix has been released🎉 |
rliberoff
added a commit
that referenced
this issue
Feb 27, 2024
- Updated `Azure.Core` from `1.37.0` to `1.38.0`. - Updated `Microsoft.Bot.Builder.Azure` from `4.22.1` to `4.22.2`. - Updated `Microsoft.Bot.Builder.Azure.Blobs` from `4.22.1` to `4.22.2`. - Updated `Microsoft.Bot.Builder.Dialogs` from `4.22.1` to `4.22.2`. - Updated `Microsoft.Bot.Builder.Integration.ApplicationInsights.Core` from `4.22.1` to `4.22.2`. - Updated `MMicrosoft.Bot.Builder.Integration.AspNet.Core` from `4.22.1` to `4.22.2`. - Updated `Microsoft.SemanticKernel.Abstractions` from `1.4.0` to `1.5.0`. - Updated `Microsoft.SemanticKernel.Connectors.AzureAISearch` from `1.4.0-alpha` to `1.5.0-alpha`. This does fix the [Issue 72](#72). - Updated `Microsoft.SemanticKernel.Connectors.OpenAI` from `1.4.0` to `1.5.0`. - Updated `Microsoft.SemanticKernel.Connectors.Qdrant` from `1.4.0-alpha` to `1.5.0-alpha`. - Updated `Microsoft.SemanticKernel.Core` from `1.4.0` to `1.5.0`. - Updated `Microsoft.SemanticKernel.Plugins.Document` from `1.4.0-alpha` to `1.5.0-alpha`. - Updated `Microsoft.SemanticKernel.Plugins.Memory` from `1.4.0-alpha` to `1.5.0-alpha`. - Updated `SharpToken` from `1.2.15` to `1.2.17`. - Updated `coverlet.collector` from `6.0.0` to `6.0.1`. - Updated `xunit` from `2.6.6` to `2.7.0`. - Updated `xunit.analyzers` from `1.10.0` to `1.11.0`. - Updated `xunit.extensibility.core` from `2.6.6` to `2.7.0`. - Updated `xunit.runner.visualstudio` from `2.5.6` to `2.5.7`.
Merged
rliberoff
added a commit
that referenced
this issue
Apr 17, 2024
- Updated `Asp.Versioning.Mvc.ApiExplorer` from `8.0.0` to `8.1.0`. - Updated `Azure.AI.OpenAI` from `1.0.0-beta14` to `1.0.0-beta16`. - Updated `Bogus` from `35.4.1` to `35.`5.0`. - Updated `MailKit` from `4.4.0` to `4.5.0`. - Updated `MimeKit` from `4.4.0` to `4.5.0`. - Updated `Microsoft.AspNetCore.Authentication.JwtBearer` from `8.0.2` to `8.0.4`. - Updated `Microsoft.AspNetCore.Authentication.OpenIdConnect` from `8.0.2` to `8.0.4`. - Updated `Microsoft.Bot.Builder.Azure` from `4.22.2` to `4.22.3`. - Updated `Microsoft.Bot.Builder.Azure.Blobs` from `4.22.2` to `4.22.3`. - Updated `Microsoft.Bot.Builder.Dialogs` from `4.22.2` to `4.22.3`. - Updated `Microsoft.Bot.Builder.Integration.ApplicationInsights.Core` from `4.22.2` to `4.22.3`. - Updated `MMicrosoft.Bot.Builder.Integration.AspNet.Core` from `4.22.2` to `4.22.3`. - Updated `Microsoft.Azure.Cosmos` from `3.38.1` to `3.39.0`. - Updated `Microsoft.EntityFrameworkCore` from `8.0.2` to `8.0.4`. - Updated `Microsoft.EntityFrameworkCore.SqlServer` from `8.0.2` to `8.0.4`. - Updated `Microsoft.Extensions.Logging.Abstractions` from `8.0.0` to `8.0.1`. - Updated `Microsoft.Extensions.Azure` from `1.7.2` to `1.7.3`. - Updated `Microsoft.Extensions.DependencyInjection.Abstractions` from `8.0.0` to `8.0.1`. - Updated `Microsoft.SemanticKernel.Abstractions` from `1.6.2` to `1.7.1`. - Updated `Microsoft.SemanticKernel.Connectors.AzureAISearch` from `1.6.2-alpha` to `1.7.1-alpha`. This does fix the [Issue 72](#72). - Updated `Microsoft.SemanticKernel.Connectors.OpenAI` from `1.6.2` to `1.7.1`. - Updated `Microsoft.SemanticKernel.Connectors.Qdrant` from `1.6.2-alpha` to `1.7.1-alpha`. - Updated `Microsoft.SemanticKernel.Core` from `1.6.2` to `1.7.1`. - Updated `Microsoft.SemanticKernel.Plugins.Document` from `1.6.2-alpha` to `1.7.1-alpha`. - Updated `Microsoft.SemanticKernel.Plugins.Memory` from `1.6.2-alpha` to `1.7.1-alpha`. - Updated `SharpToken` from `1.2.17` to `2.0.2`. - Updated `System.Text.Json` from `8.0.2` to `8.0.3`. - Updated `coverlet.collector` from `6.0.1` to `6.0.2`. - Updated `xunit` from `2.7.0` to `2.7.1`. - Updated `xunit.analyzers` from `1.11.0` to `1.12.0`. - Updated `xunit.extensibility.core` from `2.7.0` to `2.7.1`. - Updated `xunit.runner.visualstudio` from `2.5.7` to `2.5.8`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description:
Problem:
When attempting to retrieve a memory from the MemoryStore using
MemoryStore.GetAsync
, the current implementation encounters an issue specific to the Azure AI Search Memory Store. In this scenario, if the requested element does not exist, instead of returning a null value as expected, the method throws aRequestFailedException
with a status code of Http NotFound (404).Current Solution:
To address this issue, a try-catch block has been implemented to catch the
RequestFailedException
with a specific check for Http NotFound status. This prevents the exception from propagating further and allows the program to continue execution without disruption.Reasoning:
The try-catch block is a temporary solution to handle the unexpected behavior of the MemoryStore in the Azure AI Search context. Ideally, the
MemoryStore.GetAsync
method should return null when the requested element is not found, eliminating the need for exception handling in this case.Solution:
An issue has been opened in Semantic Kernel to address the root cause of this behavior. Once this issue in Semantic Kernel is resolved and our code is updated to the version of Semantic Kernel that includes the fix, we should remove the try-catch block associated with this temporary workaround.
Issue Link:
Link to Semantic Kernel Issue
The text was updated successfully, but these errors were encountered: