Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary workaround for handling Http NotFound exception in MemoryStoreExtender #73

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

LuisM000
Copy link
Contributor

@LuisM000 LuisM000 commented Feb 8, 2024

Description

This pull request addresses an issue related to issue (though it does not close it). The PR introduces a temporary fix for an error identified in Semantic Kernel. The issue arises when utilizing the AzureAISearch connector, specifically when attempting to retrieve data from the memory store for a non-existent item. Instead of gracefully handling this scenario by returning null, an exception is thrown.

Changes Made

  • Implements a temporary fix to handle the Http NotFound exception in the MemoryStore.GetAsync method.
  • Adds a try-catch block to capture the exception and prevent disruption in case of a non-existent item in the memory store.
  • Includes a note in the code to emphasize that this fix is temporary and should be removed once the underlying issue in Semantic Kernel is resolved.

Note: This fix is introduced to mitigate the current behavior of the AzureAISearch Memory Store until a permanent solution is provided in Semantic Kernel.

Related Issues

  • Fixes issue #72 indirectly by addressing a specific error mentioned in the issue.

@LuisM000 LuisM000 added the bug Something isn't working label Feb 8, 2024
@LuisM000 LuisM000 marked this pull request as ready for review February 8, 2024 09:15
@LuisM000
Copy link
Contributor Author

LuisM000 commented Feb 8, 2024

I'm aware that this PR will close issue #72 because it's referenced. I understand, and I'll reopen it once the PR is completed :)

@LuisM000 LuisM000 merged commit 113023a into main Feb 8, 2024
6 checks passed
@LuisM000 LuisM000 deleted the @lmarcos/memory_extender_exception_handling_#72 branch February 8, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling Http NotFound Exception in MemoryStoreExtender
3 participants