Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed warnings CS8603 and CS8625 in Encamina.Enmarcha.AspNet #112

Merged
merged 9 commits into from
May 2, 2024
Merged

Fixed warnings CS8603 and CS8625 in Encamina.Enmarcha.AspNet #112

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5ea968c
Revised changes
HugoRamosEs Apr 26, 2024
259ea82
Merge branch '@hramos/FixWarnings/Encamina.Enmarcha.AI' into @hramos/…
HugoRamosEs Apr 26, 2024
d4209b2
Updated CHANGELOG.md and Directory.Build.props
HugoRamosEs Apr 26, 2024
538115d
Fixed CS8625 in IMvcBuilderExtensions
HugoRamosEs Apr 29, 2024
eeb2f71
Merge branch 'main' into @hramos/FixWarnings/Encamina.Enmarcha.AspNet
HugoRamosEs Apr 29, 2024
a69445c
Merge branch 'main' into @hramos/FixWarnings/Encamina.Enmarcha.AspNet
HugoRamosEs Apr 29, 2024
2009c14
Merge branch '@hramos/FixWarnings/Encamina.Enmarcha.AspNet' of https:…
HugoRamosEs Apr 29, 2024
56ad3c0
Fixed CustomDateTimeModelBinderProvider to accept null
HugoRamosEs Apr 29, 2024
40bf566
Modified CustomDateTimeModelBinder to remove warnings in CustomDateTi…
HugoRamosEs Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Encamina.Enmarcha.AspNet.Mvc/Bindings/CustomDateTimeModelBinderProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,20 @@ namespace Encamina.Enmarcha.AspNet.Mvc.Bindings;
/// </summary>
public class CustomDateTimeModelBinderProvider : IModelBinderProvider
{
private readonly string customDateTimeFormat;
private readonly string? customDateTimeFormat;
HugoRamosEs marked this conversation as resolved.
Show resolved Hide resolved

/// <summary>
/// Initializes a new instance of the <see cref="CustomDateTimeModelBinderProvider"/> class.
/// </summary>
public CustomDateTimeModelBinderProvider() : this(null!)
public CustomDateTimeModelBinderProvider() : this(null)
{
}

/// <summary>
/// Initializes a new instance of the <see cref="CustomDateTimeModelBinderProvider"/> class with specific custom date time format.
/// </summary>
/// <param name="customDateTimeFormat">The custom <see cref="DateTime"/> format to use when binding models.</param>
public CustomDateTimeModelBinderProvider(string customDateTimeFormat)
public CustomDateTimeModelBinderProvider(string? customDateTimeFormat)
{
this.customDateTimeFormat = customDateTimeFormat;
}
Expand Down
Loading