Fixed some warnings in Encamina.Enmarcha.Email #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HugoRamosEs
commented
May 24, 2024
•
HugoRamosEs
commented
- Enhanced EmailAttachmentSpecification.cs by allowing ContentType to be nullable, addressing CS8618 warning.
- Updated EmailSpecification.cs to permit Body to be nullable, resolving CS8618 warnings.
- Modified IEmailBuilder.cs to allow senderName and recipientName to be nullable, addressing CS8625 warnings. Additionally, minor refactoring has been performed.
- Updated EmailService.cs to align with the method signatures defined in IEmailBuilder.
- Added new GPT-4o info in ModelInfo.cs.
…mos/FixWarnings/Encamina.Enmarcha.Email
…/FixWarnings/Encamina.Enmarcha.Email
…s/FixWarnings/Encamina.Enmarcha.Email
MarioRamosEs
previously approved these changes
May 31, 2024
LuisM000
reviewed
Jun 3, 2024
src/Encamina.Enmarcha.Email.Abstractions/EmailAttachmentSpecification.cs
Outdated
Show resolved
Hide resolved
LuisM000
reviewed
Jun 3, 2024
MarioRamosEs
previously approved these changes
Jun 6, 2024
LuisM000
reviewed
Jun 6, 2024
MarioRamosEs
approved these changes
Jun 6, 2024
LuisM000
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.