Updates required for new Factorial AIG project. #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main changes includes: - Added some compilation support classes to `Encamina.Enmarcha.AO.OpenAI.Azure` to support language features like the `required` keyword. - Added new property In `Encamina.Enmarcha.AI.OpenAI.Azure.AzureOpenAIOptions` called `UseDefaultAzureCredentialAuthentication` to support connections with Managed Identities. - In `Encamina.Enmarcha.AI.OpenAI.Azure.AzureOpenAIOptions` the `Key` property is now only required if properties `UseDefaultAzureCredentialAuthentication` and `UseTokenCredentialAuthentication` are both false. - In `Encamina.Enmarcha.AI.QuestionsAnswering.Abstractions`, enum type `LogicalOperations` is now marked as obsolete. It is being replace by enum type `LogicOperations` (same name) in `Encamina.Enmarcha.Core` (different project and namespace). It will be removed in future versions. - Improved data annotation `RequiredIfAttribute` from `Encamina.Enmarcha.Core.DataAnnotations` to support multiple conditions and properties. - In class `CosmosOptions` from `Encamina.Enmarcha.Data.Cosmos` added new property `UseDefaultAzureCredentialAuthentication` to support connections with Managed Identities. - In class `CosmosOptions` from `Encamina.Enmarcha.Data.Cosmos` the `Key` property is now only required if property `UseDefaultAzureCredentialAuthentication` is `false`.
MarioRamosEs
previously approved these changes
Sep 12, 2024
santypr
requested changes
Sep 12, 2024
santypr
previously approved these changes
Sep 12, 2024
LuisM000
reviewed
Sep 12, 2024
src/Encamina.Enmarcha.Core/DataAnnotations/Resources/ValudationResultMessages.resx
Outdated
Show resolved
Hide resolved
rliberoff
dismissed stale reviews from santypr and MarioRamosEs
via
73f00d3
LuisM000
approved these changes
Sep 12, 2024
santypr
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes includes:
Encamina.Enmarcha.AO.OpenAI.Azureto support language features like therequiredkeyword.Encamina.Enmarcha.AI.OpenAI.Azure.AzureOpenAIOptionscalledUseDefaultAzureCredentialAuthenticationto support connections with Managed Identities.Encamina.Enmarcha.AI.OpenAI.Azure.AzureOpenAIOptionstheKeyproperty is now only required if propertiesUseDefaultAzureCredentialAuthenticationandUseTokenCredentialAuthenticationare both false.Encamina.Enmarcha.AI.QuestionsAnswering.Abstractions, enum typeLogicalOperationsis now marked as obsolete. It is being replace by enum typeLogicOperations(same name) inEncamina.Enmarcha.Core(different project and namespace). It will be removed in future versions.RequiredIfAttributefromEncamina.Enmarcha.Core.DataAnnotationsto support multiple conditions and properties.CosmosOptionsfromEncamina.Enmarcha.Data.Cosmosadded new propertyUseDefaultAzureCredentialAuthenticationto support connections with Managed Identities.CosmosOptionsfromEncamina.Enmarcha.Data.CosmostheKeyproperty is now only required if propertyUseDefaultAzureCredentialAuthenticationisfalse.