-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version 8.1.3
- Introduced IChatHistoryProvider
interface and its corresponding implementation ChatHistoryProvider
.
#78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IChatHistoryProvider
interface and its corresponding implementation ChatHistoryProvider
.8.1.3
- Introduced IChatHistoryProvider
interface and its corresponding implementation ChatHistoryProvider
.
rliberoff
requested changes
Feb 13, 2024
src/Encamina.Enmarcha.SemanticKernel.Abstractions/IChatHistoryProvider.cs
Outdated
Show resolved
Hide resolved
src/Encamina.Enmarcha.SemanticKernel.Abstractions/IChatHistoryProvider.cs
Outdated
Show resolved
Hide resolved
rliberoff
approved these changes
Feb 13, 2024
LuisM000
reviewed
Feb 13, 2024
src/Encamina.Enmarcha.SemanticKernel.Abstractions/ILengthFunctions.cs
Outdated
Show resolved
Hide resolved
rliberoff
previously approved these changes
Feb 13, 2024
src/Encamina.Enmarcha.SemanticKernel.Abstractions/ILengthFunctions.cs
Outdated
Show resolved
Hide resolved
rliberoff
previously approved these changes
Feb 13, 2024
LuisM000
previously approved these changes
Feb 13, 2024
src/Encamina.Enmarcha.SemanticKernel.Abstractions/IChatHistoryProvider.cs
Outdated
Show resolved
Hide resolved
4b8e8ec
rliberoff
approved these changes
Feb 13, 2024
LuisM000
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new
IChatHistoryProvider
abstraction layer has been added to decouple the history management fromChatWithHistoryPlugin
, so that it can be used by other parts of the code.Changelog
Breaking Changes
HistoryMaxMessages
property fromChatWithHistoryPluginOptions
as part of a refactor to improve the configuration management of chat history. This property is now available within a new dedicated classChatHistoryProviderOptions
, which is designed to configure aspects of theIChatHistoryProvider
implementation.ImportChatWithHistoryPluginUsingCosmosDb
has been renamed toImportChatWithHistoryPlugin
to reflect its decoupling from the specific storage implementation and to align with the newIChatHistoryProvider
abstraction. This change requires consumers to update their method calls to match the new signature, and to provide an instance ofIChatHistoryProvider
in the dependency container. You can useAddCosmosChatHistoryProvider
to add an instance ofIChatHistoryProvider
that uses Azure Cosmos DB for storing chat histories.ChatAsync
method signature inChatWithHistoryPlugin
by changing the order of parameters and makinguserName
andlocale
optional. This change requires consumers to update their method calls to match the new signature.KernelExtensions.cs
andChatWithHistoryPluginOptions.cs
files inEncamina.Enmarcha.SemanticKernel.Plugins.Chat
had been moved to a new location to better align with the project's structure.Major Changes
IChatHistoryProvider
interface and its corresponding implementationChatHistoryProvider
. This new abstraction layer provides a more flexible and decoupled way to work with chat history.AddCosmosChatHistoryProvider
to the service collection extensions. This method streamlines the setup and registration ofIChatHistoryProvider
that uses Azure Cosmos DB for storing chat histories.IAsyncRepository<ChatMessageHistoryRecord>
inChatWithHistoryPlugin
, now relying onIChatHistoryProvider
for chat history management.LengthChatMessage
andLengthChatMessageWithEncoding
inILengthFunctions
to determine the length of chat messages considering the author's role.Minor Changes
Encamina.Enmarcha.SemanticKernel.csproj
to includeEncamina.Enmarcha.Data.Abstractions
.