Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@lmarcos/sk question function improvements #80

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

LuisM000
Copy link
Contributor

  • Updated the prompt in QuestionAnsweringPlugin to improve language detection in the response.
  • In the QuestionAnsweringPlugin's QuestionAnsweringFromMemoryQuery function, the previous behavior of returning null when no relevant memory results are found has been refactored. Now, the execution flow continues, generating a prompt with an empty context. This adjustment results in a response such as "I don't know" or a similar message.

@LuisM000 LuisM000 marked this pull request as ready for review February 19, 2024 15:48
@LuisM000 LuisM000 self-assigned this Feb 19, 2024
@LuisM000 LuisM000 added the enhancement New feature or request label Feb 19, 2024
@LuisM000 LuisM000 enabled auto-merge February 19, 2024 15:57
@adiazcan adiazcan self-requested a review February 19, 2024 16:24
Copy link
Contributor

@adiazcan adiazcan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@LuisM000 LuisM000 merged commit f12d534 into main Feb 19, 2024
6 checks passed
@LuisM000 LuisM000 deleted the @lmarcos/sk_question_function_improvements branch February 19, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants