Feature/update toggles jquery ui #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating fork to master 3/9/2017
Alright this isn't quite working as we expect. We need a HTML structure of... ``` accordion-wrapper h3 div h3 div h3 div ``` Here is what we have ``` accordion-wrapper toggle-wrapper h3 div toggle-wrapper h3 div ```
We just needed to define the header option for the toggles
Turns out I needed to use onInitialize or the built in event listeners would totally not work. In order to get the backend canvas working we need those events like onChildChange etc to reinitialize the accordion, and to get those events we needed to go though the right channels
|
Thanks for these changes, @kipraske! I'll obviously have to test them all thoroughly (and have a think about potential conflicts) before merging, but it looks good at first glance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of those accessibility improvements that I had mentioned about a month back here https://github.com/andrew-worsfold/tailor/issues/95
I am replacing the internal workings of the toggles element with jquery-ui-accordions which ships with wordpress by default we just need to hook it up. It is heavier than what was there before, but we don't have to worry about all the accessibility things that come with the jquery-ui widgets.
Note I couldn't get the tabs to work properly. I will comment on the issue on where I was in that process. I think our company can just deal with having only toggles and not use tabs until I get around to finishing that part of this.
Things to test: