fix: prevent commands from logging if PlayerCommandEvent is cancelled.

EndstoneMC · Dec 24, 2024 · 0719ae5 · 0719ae5
1 parent 87418c7
commit 0719ae5
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/src/endstone_runtime/bedrock/server/commands/minecraft_commands.cpp b/src/endstone_runtime/bedrock/server/commands/minecraft_commands.cpp
@@ -23,7 +23,6 @@
 #include "endstone/event/player/player_command_event.h"
 #include "endstone/event/server/server_command_event.h"
 
-using endstone::detail::EndstonePlayer;
 using endstone::detail::EndstoneServer;
 
 MCRESULT MinecraftCommands::executeCommand(CommandContext &ctx, bool suppress_output) const
@@ -33,15 +32,14 @@ MCRESULT MinecraftCommands::executeCommand(CommandContext &ctx, bool suppress_ou
         auto command_line = ctx.getCommand();
 
         if (auto *player = sender->asPlayer(); player) {
-            server.getLogger().info("{} issued server command: {}", player->getName(), command_line);
-
             endstone::PlayerCommandEvent event(*player, ctx.getCommand());
             server.getPluginManager().callEvent(event);
 
             if (event.isCancelled()) {
                 return MCRESULT_CommandsDisabled;
             }
             command_line = event.getCommand();
+            server.getLogger().info("{} issued server command: {}", player->getName(), command_line);
         }
 
         if (auto *console = sender->asConsole(); console) {