Docs/Improvement of documentation and library #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rewrote to common format - Simplified functions for types
- Removed @autodcs for proper analyses - Additional minor error fixes
|
The tests are currently failing as we have not yet registered the version of EMB which allows for deactivating all tests in Pull request 39. However, it is still possible to check for typos in the documentation. |
espenfb
reviewed
Oct 15, 2024
| while bidirectional transport utilize again the variables ``\texttt{trans\_pos}[tm, t]`` and ``\texttt{trans\_neg}[tm, t]`` as introduced above: | ||
|
|
||
| ```math | ||
| \texttt{emissions\_trans}[tm, t, p_{em}] = emission(tm, p_{em}, t) \times \left(\texttt{trans\_pos}[tm, t] + \texttt{trans\_neg}[tm, t]\right) |
There was a problem hiding this comment.
In a update of the bi-directional flow equations:
here we should also withdraw 0.5*loss(tm, t) form the sum of trans_pos + trans_neg
Co-authored-by: espenfb <[email protected]>
JulStraus
commented
Oct 16, 2024
|
|
||
| !!! todo "Loss calculations" | ||
| It looks to me that the loss calculations are not equivalent. | ||
| We have to change that. |
There was a problem hiding this comment.
I would see that as a separate Issue/PR.
| ```math | ||
| \begin{aligned} | ||
| \texttt{trans\_opex\_var}[tm, t_{inv}] = \sum_{t \in t_{inv}} & opex\_var(tm, t) \times \\ & | ||
| \left(\texttt{trans\_pos}[tm, t] + \texttt{trans\_neg}[tm, t]\right) \times \\ & |
There was a problem hiding this comment.
We can discuss that in more detail in a separate Issue/PR
- Removed check_any_data for EMB (to be included in separate PR) - Fixed docstring for `GeoAvailability`
espenfb
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows similar PRs in
EnergyModelsBaseandEnergyModelsRenewableProducersandEnergyModelsCO2. It is essentially an improvement on the documentation with a mathematical description of the individual concepts.The main aim is to:
The investment tests are furthermore included in the CI.