Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add buck2 RE rust example #361

Merged
merged 14 commits into from
Jan 9, 2025
Merged

add buck2 RE rust example #361

merged 14 commits into from
Jan 9, 2025

Conversation

nlopezgi
Copy link
Contributor

@nlopezgi nlopezgi commented Dec 9, 2024

  • Adding Buck2 RE rust example
  • Adding example to CI run
  • Fixing a couple of typos in other READMEs
  • Fix minor issue with go toolchain with latest version of Buck2

buck2/rust/BUCK Outdated Show resolved Hide resolved
@nlopezgi nlopezgi force-pushed the nlopezgi/buck2RustSample branch from 40e2a0c to 03772a8 Compare December 18, 2024 17:49
Copy link
Contributor

@TheGrizzlyDev TheGrizzlyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're using rbe as a target platform instead of an exec platform, which isn't quite accurate, is there a way to tell buck2 it's an exec platform instead?

buck2/rust/BUCK Show resolved Hide resolved
@TheGrizzlyDev
Copy link
Contributor

You're using rbe as a target platform instead of an exec platform, which isn't quite accurate, is there a way to tell buck2 it's an exec platform instead?

this comment is still pending, you're incorrectly using target platforms. You aren't targetting RBE, you're using it to run actions.

@nlopezgi
Copy link
Contributor Author

nlopezgi commented Jan 7, 2025

You're using rbe as a target platform instead of an exec platform, which isn't quite accurate, is there a way to tell buck2 it's an exec platform instead?

this comment is still pending, you're incorrectly using target platforms. You aren't targetting RBE, you're using it to run actions.

Apologies I had missed it.
I do not think there is a way to let buck2 select the execution platform from the command line.

Let me know if you prefer to have the exec_compatible attrs on the targets, if the current solution is an acceptable compromise or if you want me to explore other options.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole file is oddly formatted, can you please fix it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure which bit exactly you find has the odd formatting.

The only clear think I could see is the use of spaces in some of the section entries. I removed some of the spaces in the sections. However, it seems to me there is a mix in other .buckconfig files of the use of space for entries in secions or no spaces. See for example: https://github.com/facebook/buck2/blob/main/examples/with_prelude/.buckconfig and examples in https://buck2.build/docs/concepts/buckconfig/#configuration-files-can-include-other-files that do have the leading spaces in the entries.
Let me know if it was something else that you found odd about the formatting.

buck2/rust/README.md Outdated Show resolved Hide resolved
@nlopezgi nlopezgi requested a review from TheGrizzlyDev January 8, 2025 18:40
@nlopezgi nlopezgi merged commit 67081ec into main Jan 9, 2025
3 of 5 checks passed
@nlopezgi nlopezgi deleted the nlopezgi/buck2RustSample branch January 9, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants