-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add buck2 RE rust example #361
Conversation
nlopezgi
commented
Dec 9, 2024
•
edited
Loading
edited
- Adding Buck2 RE rust example
- Adding example to CI run
- Fixing a couple of typos in other READMEs
- Fix minor issue with go toolchain with latest version of Buck2
7773cd7
to
86e0d6d
Compare
40e2a0c
to
03772a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're using rbe as a target platform instead of an exec platform, which isn't quite accurate, is there a way to tell buck2 it's an exec platform instead?
this comment is still pending, you're incorrectly using target platforms. You aren't targetting RBE, you're using it to run actions. |
Apologies I had missed it.
Let me know if you prefer to have the |
buck2/rust/.buckconfig
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole file is oddly formatted, can you please fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure which bit exactly you find has the odd formatting.
The only clear think I could see is the use of spaces in some of the section entries. I removed some of the spaces in the sections. However, it seems to me there is a mix in other .buckconfig
files of the use of space for entries in secions or no spaces. See for example: https://github.com/facebook/buck2/blob/main/examples/with_prelude/.buckconfig and examples in https://buck2.build/docs/concepts/buckconfig/#configuration-files-can-include-other-files that do have the leading spaces in the entries.
Let me know if it was something else that you found odd about the formatting.