update buck2 samples using https://github.com/facebook/buck2/pull/826 #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlopezgi
force-pushed
the
nlopezgi/cleanUpBuck2Samples
branch
from
7c7b376 to
a12e83b
Compare
nlopezgi
changed the title
| @@ -45,6 +45,7 @@ def _platforms(ctx): | |||
| return [ | |||
| DefaultInfo(), | |||
| ExecutionPlatformRegistrationInfo(platforms = [platform]), | |||
| PlatformInfo(label = str(name), configuration = configuration), | |||
There was a problem hiding this comment.
Same as before. Plus should this even be part of this PR?
There was a problem hiding this comment.
Without these lines the builds fail with the following error:
Expected `root//platforms:remote_platform` to be a `platform()` target, but it had no `PlatformInfo` provider.
Without the str(..) call this fails with error:
error: Type of parameter `label` doesn't match, expected `str`, actual `target_label (repr: root//platforms:remote_platform)`
23c308b to
6576ccc
Compare
TheGrizzlyDev
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--target-platformsto select platform on the command line