Feature/cors #263
Feature/cors #263
Conversation
| } | ||
|
|
||
| UrlBasedCorsConfigurationSource source = new UrlBasedCorsConfigurationSource(); | ||
| source.registerCorsConfiguration("/**", configuration); |
There was a problem hiding this comment.
Do we need cors for all ecc endpoints or just for API?
There was a problem hiding this comment.
To get self-description, you're pointing to the root of ECC, so setting only API would cause CORS issues, and that's the reason why CORS is for all endpoints, but also as future proof if there will be any new modifications/features.
| private RejectionMessageService rejectionMessageService; | ||
| private FileStreamingBean fileStreamingBean; | ||
| private ResponseMessageBufferClient responseMessageBufferClient; | ||
| private InputStreamSocketListenerClient inputStreamSocketListenerWebSocketClient; | ||
|
|
||
| @Autowired | ||
| private TLSProvider tlsProvider; |
There was a problem hiding this comment.
Can you remove annotation since it is set via constructor?
There was a problem hiding this comment.
Good catch, I forgot to delete it when I refactored it.
In general, it's not mandatory, since there is a check, if it is not present, values would be set to "*" - so for everything. |
* Update properties * Upgrade GHA to use Node.js 20 * Improve handling attributes in firewall * Modify SecurityConfig to use CORS config from property file * Fix wss ssl * Update pom.xml to use latest MMP * Update CHANGELOG.md and README.md * Address PR comments * Update test to check PUT method, since OPTIONS is now allowed in Firewall Co-authored-by: Igor Balog Eng <[email protected]>
* Feature/cors (#263) (#264) * Update properties * Upgrade GHA to use Node.js 20 * Improve handling attributes in firewall * Modify SecurityConfig to use CORS config from property file * Fix wss ssl * Update pom.xml to use latest MMP * Update CHANGELOG.md and README.md * Address PR comments * Update test to check PUT method, since OPTIONS is now allowed in Firewall Co-authored-by: Igor Balog Eng <[email protected]> * [maven-release-plugin] prepare release 1.14.9 * [maven-release-plugin] prepare for next development iteration --------- Co-authored-by: Marko <[email protected]> Co-authored-by: Igor Balog Eng <[email protected]> Co-authored-by: GitHub Actions <[email protected]>
No description provided.