[Collision Monitor] Add a watchdog mechanism (#3880) #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add block_if_invalid and allow sensor specific source_timeout * remove block_if_invalid param and make it default behavior * allow unblocking if data not yet published * log source name when invalid * getData return true if invalid AND source_timeout == 0.0 * fixed logic without source feedback * fix test * rebase artefact * format artefact * better log * move per sensor param source_timeout logic to source.cpp * fix ignore invalid source behavior * add source_timeout tests * no needed anymore * fix testSourceTimeoutOverride test --------- Co-authored-by: Guillaume Doisy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update collision monitor to stop navigation when a source is not present or timed out. See original PR for more details.