Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus syntax highlighting on tasks #11

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Conversation

rick-nu
Copy link
Member

@rick-nu rick-nu commented Nov 15, 2024

What

@AJGeel added beautiful syntax highlighting. I've added some improvements.

  • Add separate highlighting for function task:<taskname>
  • Less focus on "boilerplate"
  • Match colors for tasks and section titles with the actual output of the task:info command
  • Small fix for if/then/else/fi logic

Why

I think the highlighting should have the primary focus/highlights on the tasks itself. Quickly be able to differentiate what is a task and what is a working function. This PR optimizes that.

Screenshot

Before After
image image

@rick-nu rick-nu assigned johanvo and AJGeel and unassigned johanvo and AJGeel Nov 15, 2024
@rick-nu rick-nu requested review from AJGeel and johanvo November 15, 2024 20:45
@AJGeel AJGeel merged commit 6d08b61 into production Nov 16, 2024
1 check passed
@AJGeel AJGeel deleted the focus-highlights-on-tasks branch November 16, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants