Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to git-hooks setup as config instead of link, as that is what we actually do #13

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

johanvo
Copy link
Contributor

@johanvo johanvo commented Nov 29, 2024

as that is what we actually do

What

Change the button text (and its supporting variables/filenames/etc) to refer to the method of setting up git-hooks as "config" instead of "link", as the template uses git config to setup git-hooks.

Why

Seemed better if the UI text refers to the effect it has.

@johanvo johanvo marked this pull request as ready for review November 29, 2024 18:41
@rick-nu rick-nu self-requested a review November 29, 2024 19:40
Copy link
Member

@rick-nu rick-nu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes more sense! 💪

@rick-nu rick-nu merged commit 8ff65a1 into production Nov 29, 2024
1 check passed
@rick-nu rick-nu deleted the git-hooks-naming branch November 29, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants