Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for ensembl.io.genomio.genome_metadata.extend module #308

Merged
merged 15 commits into from
Mar 6, 2024

Conversation

JAlvarezJarreta
Copy link
Contributor

Updated all methods (review docstrings, improve readability and reduce code complexity) and added unit tests for all of them.

@JAlvarezJarreta JAlvarezJarreta self-assigned this Mar 5, 2024
@JAlvarezJarreta JAlvarezJarreta changed the base branch from hackathon/feb24 to jalvarez/hack_feb24 March 5, 2024 17:16
Copy link
Contributor

@vsitnik vsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. thank you!

Copy link
Contributor

@Dishalodha Dishalodha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a tiny change

Base automatically changed from jalvarez/hack_feb24 to hackathon/feb24 March 6, 2024 16:07
@JAlvarezJarreta JAlvarezJarreta merged commit 07db31e into hackathon/feb24 Mar 6, 2024
@JAlvarezJarreta JAlvarezJarreta deleted the jalvarez/hack_feb24_r2 branch March 6, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants