Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix seq compare in integrity #338

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Fix seq compare in integrity #338

merged 3 commits into from
Apr 8, 2024

Conversation

MatBarba
Copy link
Contributor

2 fixes:

  • Use the synonyms from the seq_region json in case the GFF uses synonyms
  • The number of only_feat seq regions was incorrect

@MatBarba MatBarba requested a review from Dishalodha March 27, 2024 17:01
@MatBarba MatBarba self-assigned this Mar 27, 2024
Dishalodha
Dishalodha approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@Dishalodha Dishalodha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested !

@JAlvarezJarreta JAlvarezJarreta merged commit 6292e59 into main Apr 8, 2024
1 check passed
@MatBarba MatBarba deleted the mbarba/fix_seq_compare branch April 17, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JAlvarezJarreta JAlvarezJarreta JAlvarezJarreta left review comments

@Dishalodha Dishalodha Dishalodha approved these changes

Assignees

@MatBarba MatBarba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatBarba @JAlvarezJarreta @Dishalodha