This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
modern rebalance timelock and threshold #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgercarder
changed the title
georgercarder
commented
Jul 25, 2022
georgercarder
commented
Jul 25, 2022
georgercarder
force-pushed
the
george/code4rena/issue/143_modern
branch
from
8d8f988 to
f0e96e1
Compare
Comment on lines
353
to
364
| function getExpectedTokenValue( | ||
| uint256 total, | ||
| address strategy, | ||
| address token | ||
| ) public view returns (int256) { | ||
| return StrategyLibrary.getExpectedTokenValue(total, strategy, token); | ||
| } | ||
|
|
||
| function getRange(int256 expectedValue, uint256 threshold) public pure returns (int256) { | ||
| return StrategyLibrary.getRange(expectedValue, threshold); | ||
| } | ||
|
|
There was a problem hiding this comment.
Why are you providing this interface in the library?
There was a problem hiding this comment.
fixed here 817baf3
georgercarder
force-pushed
the
george/code4rena/issue/143_modern
branch
from
cd2b464 to
817baf3
Compare
georgercarder
force-pushed
the
george/code4rena/issue/143_modern
branch
from
8790877 to
75a8135
Compare
PeterMPhillips
approved these changes
Jul 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #143
modern version of #168