EREGCSC-2346 -- Internal Docs in Reader Sidebar #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨ See the Django Site in action ✨ |
|
✨ See the Django Site in action ✨ |
|
✨ See the Django Site in action ✨ |
|
✨ See the Django Site in action ✨ |
|
✨ See the Django Site in action ✨ |
|
✨ See the Django Site in action ✨ |
|
✨ See the Django Site in action ✨ |
peggles2
pushed a commit
that referenced
this pull request
Jan 24, 2024
* feat: right sidebar login banner * test: update doctype label snapshot test assertion to use appropriate props * feat: conditionally show public DocTypelabel * Enable debug mode * Fix 500 error when repo categories are present * Remove debug = true * feat: api method and container component setup * feat: further table setting; get categories * fix: inherit from correct mixin for section and subpart queries * feat: get selected section and fetch on hash change * feat: add mitt eventbus to replace deprecated vue 2.x root methods * feat: clear eventbus listeners before destroy/unmount * feat: fetch and watch logic * feat: display crude item list * feat: transform and load props in correct formats * feat: getFileTypeButton moved to utils * feat: logic cleanup * feat: tweaks to bettery style doc lists * feat: iron out styling * chore: refactor existing categories method for internal and external documents * chore: remove comments * emit and listen to clear sections event * chore: formatting * feat: add more space to bottom of right sidebar * fix: tweak show if empty logic and category description logic * test: update API test suite * feat: tweak login call to action * test: add unit tests for formatResourceCategories utility method * chore: improve jsdoc documentation * test: add e2e test coverage * test: update contains assertion to take env into account * test: remove potentially flaky assertions * feat: remove unneeded styles that introduced side effect --------- Co-authored-by: Caleb Godwin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves EREGCSC-2346
Description:
Adds login link to right sidebar of reader view. Once logged in, users will see internal documents related to selected subpart or section at the bottom of the right sidebar.
This pull request changes:
ContentSearchViewsetinherits from correct mixin to allow querying by sectionInternalDocsContainerVue component to fetch internal categories and docsSupplementalContentCategoryVue componentFormatResourceCategoriesutility method to handle either public resources or eternal documentsFormatResourceCategoriesutility methodmittnpm library to project to replace the deprecated Vue 2 event emitter interface in all places that it is used.mitt: https://binodmahto.medium.com/event-bus-implementation-in-vue-5eb194aed569Steps to manually verify this change: